refactor: Code cleanup Pt2 #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ninerian
commented
Oct 29, 2025
Ninerian
commented
- raised phpstan to level 7 and fixed all issues
Ninerian
requested review from
m-seidel and
staffmariusz
and removed request for
a team
- Updated phpstan.neon.dist to level 4 - Removed unused expressions in PluginSessionTest - Fixed always-true ternary in SSODataTest - Refined assertion in SSOTokenTest to avoid redundant type check - Removed unreachable code after markTestSkipped statements - Added proper assertions to make mock object usage meaningful 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Updated phpstan.neon.dist to level 5 - Fixed type parameter in HasInstanceId::hasInstanceId() method from Plain to UnencryptedToken - Removed unused Plain token import - Aligns with lcobucci/jwt library token type hierarchy 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Ninerian
force-pushed
the
code-cleanup
branch
from
e88e6fe to
3300537
Compare
- Updated phpstan.neon.dist to level 4 - Removed unused expressions in PluginSessionTest - Fixed always-true ternary in SSODataTest - Refined assertion in SSOTokenTest to avoid redundant type check - Removed unreachable code after markTestSkipped statements - Added proper assertions to make mock object usage meaningful 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Updated phpstan.neon.dist to level 6 - Added comprehensive array type annotations (array<string,mixed>) - Added missing return type declarations for all methods - Added missing property type declarations - Fixed PHPUnit mock template type resolution - Added proper DocBlock annotations for complex types - Removed unused properties - Applied fixes across src/ and test/ directories Major improvements: - AbstractToken.php: array types and return types - SSOData traits: comprehensive type annotations - Test classes: complete type coverage and mock annotations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Updated phpstan.neon.dist to level 7 - Added non-empty-string validation for JWT library methods - Enhanced AbstractToken with proper string validation for claim names and keys - Fixed SSOToken and SSOTokenGenerator with empty string checks - Improved SessionHandlerTrait type handling for session_id() return values - Added proper class-string annotations in test files - Maintained backward compatibility while ensuring type safety Key improvements: - hasClaim/getClaim methods validate non-empty claim names - Key handling methods validate non-empty PEM strings and file paths - Session handling properly manages string|false vs string|null types - All string parameters validated before passing to strict library functions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Ninerian
force-pushed
the
code-cleanup-pt2
branch
from
1fa3c3c to
6a34427
Compare
Ninerian
force-pushed
the
code-cleanup
branch
from
acc47ef to
0ed5e27
Compare
m-seidel
requested changes
Nov 20, 2025
Contributor
m-seidel
left a comment
m-seidel
left a comment
There was a problem hiding this comment.
Could you also run the linter and commit the changes from it.
It brought up some changes in
modified: src/AbstractToken.php
modified: test/SSOData/SSODataTest.php
Comment on lines
+40
to
+42
| /** | ||
| * @return mixed | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @return mixed | |
| */ |
This is a duplication
Comment on lines
46
to
+51
| * | ||
| * @return array | ||
| */ | ||
| /** | ||
| * @return array<string, mixed> | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| * | |
| * @return array | |
| */ | |
| /** | |
| * @return array<string, mixed> | |
| */ | |
| * | |
| * @return array<string, mixed> | |
| */ |
Comment on lines
+34
to
+42
| * @param string $privateKey private key | ||
| * @param array $tokenData associative array of claims | ||
| * @param Signer|null $signer the Signer instance to sign the token, defaults to SHA256 | ||
| * | ||
| * @return string Encoded token. | ||
| */ | ||
| /** | ||
| * @param array<string,mixed> $tokenData | ||
| */ |
Contributor
There was a problem hiding this comment.
This seams to be a bit mixed up
Comment on lines
58
to
+63
| * @param array $tokenData | ||
| * @return Token | ||
| */ | ||
| /** | ||
| * @param array<string,mixed> $tokenData | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param array $tokenData | |
| * @return Token | |
| */ | |
| /** | |
| * @param array<string,mixed> $tokenData | |
| */ | |
| * @param array<string,mixed> $tokenData | |
| * @return Token | |
| */ |
Comment on lines
+50
to
+52
| /** | ||
| * @return array<string,mixed> | ||
| */ |
Contributor
There was a problem hiding this comment.
Pleas update the commented return line above and remove the duplication
| * @return array Associative array of claim accessors. | ||
| */ | ||
| /** | ||
| * @return array<string,string> |
Contributor
There was a problem hiding this comment.
Pleas update the commented return line above and remove the duplication
Contributor
There was a problem hiding this comment.
I don't think it is needed
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.